David Luzar

Results 833 comments of David Luzar

Still using grunt coz we have a build pipeline that's hugely dependent on it. So for handlebars, it's a just another grunt task we register.

@flyingL123 our task is pretty huge coz it does many other things, but I've factored out the gist of it, for you ;) 1. First, install necessary packages ``` $...

@adarkforce yes, this is what we'll want to do. Probably best to use https://www.radix-ui.com/docs/primitives/components/context-menu for this. But, before we do that, this should land first: https://github.com/excalidraw/excalidraw/issues/5926 (in progress)

Should be implemented using [@radix-ui/react-context-menu](https://www.radix-ui.com/docs/primitives/components/context-menu), or possibly reuse [@radix-ui/react-dropdown-menu](@radix-ui/react-dropdown-menu) (we'll soon be using for main menu) if it turns out that the contextmenu adds too much size on top of...

Hi @jamiecjm, sure thing! I'll send you the design spec tomorrow. Implementation-wise, let's use the `@radix-ui/react-dropdown-menu` package we're using in https://github.com/excalidraw/excalidraw/pull/6483 (you don't need to wait for the PR to...

@jamiecjm here's the context menu design spec: https://www.figma.com/file/EvavjRtXUmHjrcNIBTAMxI/Public-components?type=design&node-id=9%3A649&mode=design&t=nawGicyIY1jpomIp-1

@jamiecjm I've added the dark mode. And by mistake the figma design I posted above was using a color scheme we will deploy later and does not reflect the current...

Oh, thanks for noticing that! We should fix this, but one problem we can't release a new version currently (some things need to be updated with respect to the new...

Missed this issue. Reopening as there are numerous issues with this still. I could list the issues still present, but I'm sure I'd miss some. We should try to find...

> I think we should keep both, the main reason being the arrowheads could be removed or added later depending on the use case so it might be ambiguous when...