David Luzar
David Luzar
Awesome! Let's see what we break! 🔥
I'm not sure what we can do here. We're constrained by what button type the browser emits and by the API we can use. > but this simply scrolls down...
Since we're keeping `appState.name`, I propose document it as the "user preferred (file)name for current editor session", and prefer it to `props.name` even when `props.name` is defined. This goes hand...
Made a change here to keep `name` as optional for user-facing export functions [`f1c038b` (#7666)](https://github.com/excalidraw/excalidraw/pull/7666/commits/f1c038b5f61a449b1ffecf700fe9270514fded98) to not break the API Makes it slightly less safe for us too, alas.
I've added some comments, mainly for cases where we convert array to map in hot paths where we shouldn't be doing this (both the looping and allocations) for perf and...
> Also there are few functions `getElementsIntersectingFrame`, `groupsAreAtLeastIntersectingTheFrame` and `groupsAreCompletelyOutOfFrame` which seem to be unused so do we want to keep it ? I was wondering myself. @ryan-di were the...
- [ ] We shouldn't have a global getter that we use all over the app. It's duplicating the logic (in every place we need to do `props.name || getFileName()`...
> We can remove the appState.name prop completely, I will be raising a separate PR for it and and might have to test backward compact as well Any reason not...
Thanks for the PR @ryan-di! 🚀
Yeah, the double filter is not ideal and also canvas filters don't work on Safari as mentioned. The solution is to move away from using filters for dark mode, and...