Dustin Swales
Dustin Swales
This has been replaced by [NCAR/67](https://github.com/NCAR/ufs-weather-model/pull/67)
@lisa-bengtsson Did you try any other SDFs? I ask because the commonality between these two is that they have Thompson MP enabled. I wonder if this issue is present in...
> I think dummy array `prsi` in `lakeini` subroutine in SFC_Models/Lake/CLM/clm_lake.f90 should have dimensions `(IM,KM+1)` > > ```diff > diff --git a/physics/SFC_Models/Lake/CLM/clm_lake.f90 b/physics/SFC_Models/Lake/CLM/clm_lake.f90 > index 8686221f..94ad9d81 100644 > --- a/physics/SFC_Models/Lake/CLM/clm_lake.f90...
git clone --recursive --branch feature/gfdlmpv3 https://github.com/dustinswales/ufs-weather-model.git
@jshaw35 Thanks for tracking this down and opening up this issue!!! Just a brief comment. There has always been a difference in how SGS variability is handled in COSP and...
Hi @brian-eaton Yes, the three proposed changes you listed are needed. Good job tracing down the mixing-ratio discrepancy between [cospsimulator_intr.F90](url) and [zm_conv_intr.F90](url). Given how sprawling the coupling to COSP is,...
@peverwhee dyn_const_prop_0 and dyn_const_prop_1 are defined with the target attribute, but it's not needed. Is this intentional, or possibly an oversight/err by me in my previous commit?
> Quoting a suggestion on this topic from @gold2718 that was brought up in a different PR: > > > Here is an idea (not to be implemented here). Right...
@peverwhee This is great. It goes beyond comparing just the attributes in .Fortran/.meta files and does all of the "necessary Capgen compliance testing" (e.g. argument order checking, routines defined in...
This all seems sensible to me, but isn't the governance of development outside of "main" none of our business?