ufs-weather-model
ufs-weather-model copied to clipboard
Address ccpp-physics issues
PR Checklist
-
[x] This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
-
[x] This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
-
[x] An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.
-
[ ] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
-
[ ] New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR contains changes to GFS_typedefs.* to accommodate changes in ccpp-physics:956. There are no changes to the results.
Issue(s) addressed
- Remove all instances of physparam.f. 448
- Bug in gcycle.F90. 672
- Missing metadata hooks in gsl drag suite. 764
- Fix file extension for pre-processor directives. (.f90->.F90). 886
- Replace "stop" statements with CCPP error handling. 913 Along with the physparam.f cleanup in #488, instances of physcons.f were removed for the touched subroutines, mostly the rrtmg radiation.
Testing
Testes on Cheyenne with Intel. All RT's passed. No changes to baselines.
- [ ] hera.intel
- [ ] hera.gnu
- [ ] orion.intel
- [x] cheyenne.intel
- [ ] cheyenne.gnu
- [ ] gaea.intel
- [ ] jet.intel
- [ ] wcoss2.intel
- [ ] acorn.intel
- [ ] opnReqTest for newly added/changed feature
- [ ] CI
@dustinswales I failed to compile, for example, RT control_p8. I got the following error: CMake Error at CMakeLists.txt:292 (add_executable): Target "ufs_model" links to target "w3nco::w3nco_d" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?
This has been replaced by NCAR/67