Results 39 comments of Dustin Graham

Hi @ItsLhoudini sorry for the delay. I've reviewed the code, but I don't think I can come up with a clever way to work around this. One option would be...

Not sure if that's a bug or a feature enhancement. Seems like support could be added, so just a totally aside thought, but perhaps you could use optional route parameters...

https://github.com/lavary/laravel-menu#named-routes What did you try? Can you provide some more code of your routes and menu that are not working?

Anyone want to take a stab at this with a PR? Would anyone still benefit from this functionality?

Good idea. I wonder if it could be improved to fallback to active_class if the more granular active_class_link isn't set. If someone wants to make this into a PR I...

A pull request is welcome.

I wonder if this is related to #246 perhaps the active class is conflicting. I'll need to look into it.

Yes, sounds like there might be a bug with the active class overwriting the classes. If you have control over the CSS you might avoid adding classes to the link,...

I have not looked at this myself, but if this is the case, a PR for the documentation could be useful.

Could you clarify on the benefit of this? I've used container DI before. Where you can say `$container->resolve(AdminMenu::class)` and it would build and return the menu based on the config....