Dustin Graham comments

Results 39 comments of


                                            Dustin Graham

Basset serving development collections on production environment

I have also invested a significant bit of time into this package in the last couple months. A heads up would really be appreciated. Does Grunt compile less stylesheets and...

Add rider cache directory to Unity ignore list

This is a good change. I do this manually for each project right now.

activate_parents not works if child id is less than parent's one

Thanks for the report. I don't have time to dig into, but sounds like a good issue for a PR if someone wants to take look.

Methods get and item don't work with utf8 titles

``` Menu::make('sbMenu', function(){}); Menu::get('sbMenu')->add('Пользователи'); $x = Menu::get('sbMenu')->get('Пользователи'); dd($x); ``` Seems to work for me. Did you add `Пользователи` to the menu first?

Methods get and item don't work with utf8 titles

What do you mean by still buggy? Are you inspecting the results of each `get` and `add`? I wouldn't be surprised if it's not utf8 friendly, but I don't know...

Methods get and item don't work with utf8 titles

Strange, that's exactly what I tried. I wonder if there are other differences in my php configuration. Have you seen this before, is there any common technique or shortfall of...

Methods get and item don't work with utf8 titles

I suppose you could set the nickname manually. `->nickname('Пользователи')` but, yes the search by nickname is pretty core to this package. If we change that, it could break many implementations....

Methods get and item don't work with utf8 titles

Both good ideas, and good points.

Nested groups do not work.

https://github.com/lavary/laravel-menu#nested-groups `A menu group merges its own attribute with its parent group then shares them between its wrapped items:` Groups are not nested menus. Groups do not create a new...

Nested groups do not work.

Yes, bug in either documentation or implementation. Did a quick test and I would have thought the following would work. But, it doesn't. So yes, something is wrong. Thanks for...