Duncan Sutherland

Results 135 comments of Duncan Sutherland

> These should ideally be swapped around, there is no functional change. Apologies, could you elaborate on "swapped around"?

> Only thing I disagree with so far is I don't think the `cxt_studio` should be included in this. It's currently implemented as a 4x4 macropad, but it's actually a...

> Might be more that I missed. thanks @fauxpark, corrected as of [c9255ef](https://github.com/qmk/qmk_firmware/pull/21855/commits/c9255ef41f81c6f656eb5b1dbab5df33d1045317)

> `handwired/arrow_pad:pad_21` seems to be failing, the rest look unrelated. I'm glad you've picked up on that one! Thankfully I've not touched it but having looked at it many moons...

Applied fix for `handwired/arrow_pad:pad_21`, though in fairness it really could do with being addressed properly in a separate PR.

this PR segmented alphabetically into smaller PRs

Please label this PR as awaiting review

Please label as awaiting review

Could I recommend the following directory name changes: - /keyboards/asmodus/plaquead/plaquead -> /keyboards/asmodus/plaquead/standard - /keyboards/asmodus/plaquead/plaqueadrgb -> /keyboards/asmodus/plaquead/rgb and create /keyboards/asmodues/plaquead/rules.mk file containing: `DEFAULT_FOLDER = asmodus/plaquead/standard`

Recommendation: As `default` and `via` keymaps for `standard` and `rgb` versions are identical, `keymaps` directory can be moved into same directory level as `standard` and `rgb` directories. Alternatively, to keep...