qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add support for plaque AD

Open MaiTheSan opened this issue 1 year ago • 7 comments

Description

Add QMK support for Plaque A.D TKL

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

MaiTheSan avatar Mar 26 '24 21:03 MaiTheSan

Could I recommend the following directory name changes:

  • /keyboards/asmodus/plaquead/plaquead -> /keyboards/asmodus/plaquead/standard
  • /keyboards/asmodus/plaquead/plaqueadrgb -> /keyboards/asmodus/plaquead/rgb

and create /keyboards/asmodues/plaquead/rules.mk file containing: DEFAULT_FOLDER = asmodus/plaquead/standard

dunk2k avatar Mar 27 '24 08:03 dunk2k

Could I recommend the following directory name changes:

  • /keyboards/asmodus/plaquead/plaquead -> /keyboards/asmodus/plaquead/standard
  • /keyboards/asmodus/plaquead/plaqueadrgb -> /keyboards/asmodus/plaquead/rgb

and create /keyboards/asmodues/plaquead/rules.mk file containing: DEFAULT_FOLDER = asmodus/plaquead/standard

yea, I did

MaiTheSan avatar Mar 27 '24 09:03 MaiTheSan

Recommendation: As default and via keymaps for standard and rgb versions are identical, keymaps directory can be moved into same directory level as standard and rgb directories.

Alternatively, to keep distinction of versions, keymaps in rgb directory could have an additional layer that contains RGB related keycodes 🤔

dunk2k avatar Mar 27 '24 13:03 dunk2k

Recommendation: As default and via keymaps for standard and rgb versions are identical, keymaps directory can be moved into same directory level as standard and rgb directories.

Alternatively, to keep distinction of versions, keymaps in rgb directory could have an additional layer that contains RGB related keycodes 🤔

as you said 😉

MaiTheSan avatar Mar 27 '24 13:03 MaiTheSan

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 23 '24 01:06 github-actions[bot]

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Oct 11 '24 02:10 github-actions[bot]