Duncan Sutherland

Results 135 comments of Duncan Sutherland

> I added all the available layouts, please review any corrections if necessary! @Deemen17 excellent work, thank you!

@Deemen17 running `qmk info` * `-l` (alternatively, using Crtl+Shift+I in QMK configurator) on the layouts you've added shows the key width and spacing (on bottom row) don't match that of...

Does `keyboards/olly/jf/matrix_diagram.md` apply to both rev1 and rev2? It appears, from layout information, that aforementioned file is applicable to rev1 only. Could it be moved into rev1 directory and have...

could you add a `rules.mk` file in directory `keyboards/keycapsss/kimiko` defining default folder to either rev1 or rev2 sub directory? (am assuming rev2 would be the desired default) `DEFAULT_FOLDER = keyboards/keycapsss/kimiko/rev2`

CI build failures for keymaps in `rev1` directory is to be expected as this PR is intended to be in conjunction with the Update rev 1 PR. As long as...

@BenRoe I have a fix but what it would entail: 1. reverting rev1 related code back to it's original state but with added `#ifdef`s, in `kimiko.c` and `rules.mk` to logically...

> @dunk2k thank for the quick help. Rev1 and Rev2 default keycaps compile. The if code in the rule.mk does not work correct. Get `keycapsss/kimiko/rev2: SPLIT_KEYBOARD in rules.mk is overwriting...

> thankfully a warning's not a disqualifiable but the lint check I can't fix/get around; I've tried a `post_rules.mk`, with ifeq code block, placed in `keycapsss/kimiko` dir and same file...

> Pushed your suggested changes. Also checked the `ifeq ($(strip $(KEYBOARD))` code on other keyboards and it's the same. Strange Lint successful. Build is in progress. Wow what a PR....