dundargoc

Results 302 comments of dundargoc

> Which part of the above plan, specifically, do you want to change, and how, specifically? The proposed strategy is alright I guess, it's just more safe/careful than my personal...

> the automated "Update README" PR for example does not need any tests). Tests are only run on the automated PR because they're being closed and reopened manually by someone....

Aha, so it's needed for the "Updated Parser" PR but not "Update README" PR? Gotcha. For the "Update README" PRs the simplest way to skip tests would be to not...

The CI logs show that swift highlights take around 370 seconds, which is around >90% of the entire job (ubuntu-latest, gcc, stable). This job is also the one that usually...

Thanks for the explanation :+1: This is good news, means that this particular bottleneck will solve itself in due time then.

Maybe I don't fully get the usecase, but would `$NVIM_APPNAME` not be one way to accomplish trying out plugins without affect global state?

> Ok this should be investigate further before doing anything. Why? He literally said he'd merge this unless any maintainers strongly disagreed, which they haven't. You will not be making...

> (Also, it's not a great sign that each of the four -- so far -- PRs adding CMake support has essentially been completely different... And for reference, the [CMakeLists.txt](https://github.com/neovim/neovim/blob/master/cmake.deps/cmake/TreesitterCMakeLists.txt?rgh-link-date=2024-08-21T09%3A18%3A53Z)...

IMO the cmake file looks good and it's a positive for downstream consumers who also use cmake. Don't see a problem with it personally. I'll defer to the core devs...

> @roket1428 thanks for checking. I'll try to merge it soon, remind me in a few days. @justinmk How about a few years ;)