dundargoc

Results 302 comments of dundargoc

I *think* it's possible to move the parsers download/installation to main build. Only question is if it makes sense to do in general and if other distributions have a problem...

We can't vendor parsers atm as they'd be system dependent. If vendoring parsers is the approach we wanna take then we need wasmtime up and running first.

> Absolutely. This is why I suggested to put them into release tarballs only, not into the repo. Then that is not vendoring in neovim(?) lingo, vendoring is including external...

> You are changing libvterm too Ye, I figured I could deal with the low hanging fruits from there as well. Should I postpone it to a future PR?

> Not sure we want to yeet all debug output? That can be helpful. Yeah I changed my mind and reverted it.

Moved the code to `tui/termkey`. Kinda starting to wonder if the PR is worth it tho if we want to keep the two codes separated.

> Would that support symbols Doesn't that require something like treesitter to figure out what's happening in the file? I believe it should be fine for markdown and C but...

> idk why the news check passed, but this probably should be mentioned in news. It is not magic. It is only triggered if a commit message (not PR title)...

I can't recreate this, neither on macos or on centos docker container. I wonder if this might be related to the cmake version somehow. Do you have the possibility to...

Also, could you link to the full build/install logs in a gist or something? I'd like to see what actually happens.