Danny Turner
Danny Turner
**What are you trying to accomplish with this PR?** E.g. If a CRD defines a Kind that is also in our hard coded predeploy_sequence, but with a different group, only...
# Bug report There was an error during a deployment that caused the kubeconfig.yml to be logged. The kubeconfig included an access-token. While access-tokens are short lived we shouldn't be...
One component of the impact of Krane is its use external to Shopify. Starts are a poor proxy of use. We don't want to add phone-home code either. So to...
- [x] yank Krane 0.27.0.pre - [ ] PVC issue in tests - [ ] Deploy tests that require erb rendering (@RyanBrushett) - [x] CR prune tests moved to serial-integration...
As part of [Consistent preflight validations for all tasks](https://github.com/Shopify/kubernetes-deploy/issues/344) we created a `TaskConfig` class. The high level idea of this class was that it could be passed around instead of...
# Problem #548 added the `Krane restart` command. However, the `-f` flag as explained in https://docs.google.com/document/d/1oInUsKplYGNWTymPY48xtDCx3x4Cwc-phcEKUkt2v4U/view# was not added. # Possible solution Add the flag. Note: Thor merged erikhuda/thor#674 (allows...
# Bug report CI fails on valid PRs from external contributors. This happens because the CI step is unable to check out the code https://buildkite.com/shopify/kubernetes-deploy/builds/51 **Expected behavior:** CI passes **Actual...
`_succeeded?`, `_failed?`, `_timed_out?` and (effectively) [`_ignored?` ](https://github.com/Shopify/kubernetes-deploy/pull/282) should all be mutually exclusive, but there's nothing forcing them to be, and if they aren't in practice, what we'll show depends on...
The following file isn't parsable: ```jinja {%- raw -%} 123 {%- endraw -%} ``` The parser gives this error: > Unable to parse statement "raw": Unexpected EOF, expected tag endraw....