krane
krane copied to clipboard
[Bug Fix] predeploy_sequence is wrong when there are conflicts between built-ins and CRDs
What are you trying to accomplish with this PR? E.g. If a CRD defines a Kind that is also in our hard coded predeploy_sequence, but with a different group, only one will be pre-deployed. That's a bug.
Fix: https://github.com/Shopify/krane/issues/773
How is this accomplished? The predeploy sequence now supports multiple groups per Kind.
This needs some tests too
What could go wrong? This actually isn't the fix, it has a sublte bug where we'll always deploy something with that name ...
Or that this code is ugly and we really need an object instead of a hash...