Damon Tivel

Results 37 issues of Damon Tivel

Two tests failed then passed on rerun for https://github.com/dotnet/sign/commit/394fc50bebb3ddaa3f79fc975f552d4ea2787552: * [`Sign.Core.Test.OpcPackageSigningTests.ShouldTimestampFileWithRsa(keySizeInBits: 2048, hashAlgorithmName: SHA256, timestampDigestAlgorithm: SHA256)`](https://github.com/dotnet/sign/blob/394fc50bebb3ddaa3f79fc975f552d4ea2787552/test/Sign.Core.Test/Tools/VSIXSignTool/OpcPackageSigningTests.cs#L66) details ``` System.Security.Cryptography.CryptographicException : ASN1 corrupted data.\r\n---- System.Formats.Asn1.AsnContentException : The provided data does not...

Priority:2
test

With https://github.com/Azure/azure-sdk-for-net/pull/33186 merged, we should use Azure SDK's `RSA` implementation instead of https://github.com/novotnyllc/RSAKeyVaultProvider. CC @clairernovotny

Priority:1

Currently, Sign CLI only supports signing with Azure Key Vault. Sign CLI should support pluggable signature providers to enable other private key storage options. CC @clairernovotny

feature-request
Priority:1

Resolve https://github.com/dotnet/sign/issues/631. This change enables NuGet.org to locate and read the README.md already in the NuGet package. CC @clairernovotny

https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packagereadmefile

## Sign * https://github.com/dotnet/sign/issues/624 ## ClickOnce * https://github.com/dotnet/deployment-tools/issues/275 * https://github.com/dotnet/msbuild/issues/8755 * https://github.com/dotnet/sign/issues/630 ## VSIX * https://github.com/dotnet/sign/issues/561 CC @clairernovotny

**Describe the bug** If I hack a timestamp service to return a timestamp using SHA-1, Sign CLI blindly allows it. In the case of NuGet package signing, inner PE file...

bug
Priority:2

The version of Globber.cs comes from a 2017 commit. There have been changes in the source repository since then. We should take the latest version, reapply local changes, clean up...

Priority:2

Related: https://github.com/dotnet/sign/issues/539

Priority:2

At least redirect to https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.loglevel?view=dotnet-plat-ext-7.0#fields

documentation
Priority:3