Damon Tivel

Give good error message at startup when platform is unsupported

2

CC @clairernovotny

MaxConcurrency should allow -1

1

[Sign CLI disallows -1 for the `--max-concurrency` option](https://github.com/dotnet/sign/blob/7b32935c42c720d96ceee799980a7f5ec2d2c296/src/Sign.Cli/CodeCommand.cs#L77-L89) just as [SignService did](https://github.com/dotnet/sign/blob/legacy-service/servicing/src/SignClient/SignCommand.cs#L252-L256), but [-1 has special meaning and should be allowed](https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions.maxdegreeofparallelism?view=net-7.0#remarks). CC @clairernovotny

## Sign * https://github.com/dotnet/sign/issues/559 * https://github.com/dotnet/sign/issues/564 ## ClickOnce * https://github.com/dotnet/sign/issues/563 * https://github.com/dotnet/sign/issues/562 ## NuGet * https://github.com/dotnet/sign/issues/539 * https://github.com/dotnet/sign/issues/547 ## VSIX * https://github.com/dotnet/sign/issues/561 * https://github.com/dotnet/sign/issues/536 * https://github.com/vcsjones/OpenOpcSignTool/issues/76 * https://github.com/vcsjones/OpenOpcSignTool/issues/75 CC @clairernovotny

We should have a test for a subject name that contains internal quotes and commas. Many parsers fail at that. For example, this is a valid DN: `CN="Contoso, Inc", O="Fabrikam,...

Upvote if Windows x86 is important to you.

> nit: consider an introducing some idiom in the codebase that allows succinct file extension checking. Maybe it's a new LINQ method (`SingleExtension` or `WhereExtension`) or a helper method called...

See https://github.com/dotnet/arcade/issues/7300

https://github.com/dotnet/arcade/blob/main/Documentation/DependencyFlowOnboarding.md

We shouldn't own copies of .NET Framework manifest-signing code (e.g.: [mansign.cs](https://github.com/dotnet/sign/blob/acd95606604d6ff41135556a348c4b1c521c1ef3/src/Sign.Core/Native/mansign.cs) and [mansign2.cs](https://github.com/dotnet/sign/blob/acd95606604d6ff41135556a348c4b1c521c1ef3/src/Sign.Core/Native/mansign2.cs)). We should delete all this code and move to a solution that does this for us. See...