David Taylor

Results 21 issues of David Taylor

Previously when checking if a value was a zero value to determine if it should be elided when EmitDefaults was true, some types of values were not being correctly inspected...

[RFC3962 (4)](https://datatracker.ietf.org/doc/html/rfc3962#section-4) stipulates that a `00 00 00 00` be changed to 2^32, which currently motivates using an int64, instead of an int, to hold its value when calling pbkdf2...

[RFC3962 (4) says](https://datatracker.ietf.org/doc/html/rfc3962#section-4) that a value of `00 00 00 00` should be interpreted as 2^32 (ie `rfc3962.s2kParamsZero`). Currently [`rfc3962.S2KparamsToItertions`]( https://github.com/jcmturner/gokrb5/blob/master/crypto/rfc3962/keyDerivation.go#L43) attempts to decode the iteration count string and returns...

fixes https://github.com/cockroachdb/cockroach/issues/88345 Release note: none.

### What version of rules_go are you using? v0.34.0 ### What version of gazelle are you using? v0.26.0 ### What version of Bazel are you using? 5.2.0 ### Does this...

``` defer func() { mutex.Lock() syms = append(syms, v.syms...) mutex.Unlock() }() defer wg.Done() ``` The wait group is unblocked by [the deferred Done()](https://github.com/newhook/go-symbols/blob/master/main.go#L222). Since that is deferred *after* the [deferred...

Backport 3/3 commits from #119572. /cc @cockroachdb/release --- Release note: none. Epic: none. Release justification: low-risk, high impact observability improvement.

backport

Backport: * 6/6 commits from "pkg/cloud: add metrics for readers/writers/listings/conn reuse/tls" (#115517) * 1/1 commits from "cloud: add gauges for open cloud readers and writers" (#119571) Please see individual PRs...

backport

This helps line it up with the pprof labels Release note: none. Epic: none.

First commit is #119315. Release note (breaking change): the --config-profile command line flag added for preview support of PCR in the previous release has been removed. Nodes, including those for...