David Taylor

hm pretty sure anything that was _in_ GOPATH will have `src`: https://github.com/golang/go/wiki/GOPATH#directory-layout if you somehow got Go to build something that wasn't in GOPATH, well then trimming `GOPATH` off it...

> figure out how to get our hands on URLs to authorize during planning I believe this is impossible: URIs can appear in placeholders, so we don't have their values...

How do we know the descriptors though? like, just lease _all_ possible synthetic / privilege descriptors? Until we look at the URI, we don't know if it is a named...

But what if the uri is to a userfile location? Until we parse the host we don't even know what table name to resolve let along priv check

This looks very similar to the closed issue https://github.com/bazelbuild/rules_go/issues/3015, but that was marked as fixed by @illicitonion and @linzhp in https://github.com/bazelbuild/rules_go/pull/3116, which is in v0.34.0, which is what I am...

> list in the commit message some of the things we found suboptimal about the config-profiles Done.

> believe the plan is to chat through this at the next Friends of MT meeting. I interpreted that suggestion as a retrospective review of the stack of changes that...

TFTR! bors r+

> Failing at compile time or before the test starts would be great This seems like way more work than it would be worth for what is, to be clear,...

Previous backport-speckific review discussion on the 23.2 version of this PR: https://github.com/cockroachdb/cockroach/pull/119563#issuecomment-1960635701