Dave Syer

Results 522 comments of Dave Syer

Here's a prototype that works for `Future` and `CompletableFuture`: https://github.com/dsyer/spring-retry/tree/future. Similar features for e.g. reactor types (`Mono` in particular) would be trivial. To make it work on master we would...

Yes, that bit will be hard. I’m not sure I want add new methods to existing interfaces yet, either. Also note that Spring has some abstractions already for scheduling and...

I get what you mean about `Future` and mixing async with non-async, but on the other hand, that's what a `Future` is, so if the user decided to use it,...

Does it not work already (I think it works with Java 6)? Most likely in 2.0 we will move to Java 8 though.

I reverted #88 because there is a failing test for me. Not sure why yet.

Re-opened in case we actually want to change the default.

Is that a question? Feature request? Not sure how to respond since we already use AOP for `@Retryable`.

Nesting `@HystrixCommand` inside a retry callback is somewhat of an odd thing to do (Hystrix has retry built in). You could fix it with a custom exception classifier if you...

I guess I was confused. We use Hystrix with Ribbon/Feign/Zuul so much I probably thought the retry features were in the former not the latter. If you work out how...

I have found that I want to document the existence of the fields (with some brief description) in the table (or something similar), and then make more detailed notes about...