Dave Syer

Results 522 comments of Dave Syer

> About RetrySynchronizationManager > Supported partially. There is no way to implicitly pass the context into the worker thread, because the worker executor, True, but it's a really common pattern....

I rebased and did some tidying up: https://github.com/dsyer/spring-retry/tree/ashamukov-async-retry. We can start from there if anyone is interested in this. It works for `CompletableFuture` and `Future` (as least as much as...

Sorry, I'm not sure what code you are talking about. Would you like to propose a change in a pull request? Or be a bit more specific about where the...

Seems like a reasonable goal theoretically. But why would you not just change the parameters of the circuit breaker? What is the benefit of a composite that you don't get...

I guess it would be good to look at the change, and see some tests. Anyone feel like sending a PR?

Thanks for that, and for the tests. I was wondering if it might be better implemented a layer below the interceptors, so that someone using `RetryTemplate` directly could benefit. The...

Sorry for the delay. It's a tough decision. `RetryTemplate` tends to be global, but the decision to rethrow the original exception might be local. So on balance I guess you...

It's not really a `@CircuitBreaker` feature is it (the `RetryTemplate` always wraps the last failed exception)? It has been like that since the beginning, and therefore there might be reasons...

I had wondered some time ago whether `RetryTemplate` could be adapted to behave differently for a `RetryCallback` that returns an async type (like a `Future` for instance). I don't see...

There is a public API in `RetryTemplate` too, and `RetryCallback`, neither of which is explicitly synchronous, since they are parameterized with the return type, and that can be an async...