Dave Syer
Dave Syer
> I don't want to be careful about the proto files and I can not gather them into my gateway That's how gRPC works - you literally can't do anything...
We decided we can prototype something based on the Spring Cloud config client code: it's opt in, and also only on if spring-retry is on the classpath. In that case...
This works for me: ```java package com.example.demo; import java.sql.Connection; import java.sql.SQLException; import javax.sql.DataSource; import org.springframework.beans.BeansException; import org.springframework.beans.factory.config.BeanPostProcessor; import org.springframework.boot.SpringApplication; import org.springframework.boot.autoconfigure.SpringBootApplication; import org.springframework.context.annotation.Bean; import org.springframework.core.Ordered; import org.springframework.core.annotation.Order; import org.springframework.jdbc.datasource.AbstractDataSource; import...
How about "don't use Spring Boot 1.3.6"? I used 1.5.3.
Maybe that's a bug too then? I mean, this seems like a reasonable use case to me. OTOH I suppose you can always add `sample.location=${user.home}/foo` to `application.properties`.
Agree - to me the equivalence between `@DefaultValue` and a field with an initializer seems false.
Escaping is kind of important. I’m surprised we have got this far without explicit support for it. But @odrotbohm is right: it’s not specifically a problem with `@DefaultValue`.
My specific concern was https://github.com/spring-projects/spring-grpc/issues/19, but I do genuinely think it is more widely applicable than that (as the Armeria example shows nicely). Anything that solves #7138 might solve my...
Sounds fine to me. I might somewhat prefer an actual API, e.g. porting an idiom from Go (for instance), but this works for me and it makes sense in Java.
I don't understand the CI failures and I can't figure out how to run them myself. Are they even relevant to this PR?