Dave Syer

Results 522 comments of Dave Syer

I'm really very open to suggestion. It's part of the Guice API, but not one that has a direct parallel in Spring (child contexts I guess).

It's whitespace. Not worth the effort of chasing the CLA.

This should not be necessary. Please check your environment for JDK java compiler arguments not provided by the build scripts here (e.g. in your IDE).

We've talked about it before but never really had a consensus on what should go into the manifest. There are lots of choices and not many are obviously right. If...

That would be a useful reference for anyone wanting to contribute. Also see here for some working example code: https://github.com/dsyer/spring-petclinic/tree/k8s. I would say we need as few lines of YAML...

I can only see question marks ("????" etc.) in `messages_cn.properties`, in browser and also when I checkout your branch. Did it get destroyed on the way to github, or on...

I see the content now, thank you. Did you test it in a browser? I think the code for Chinese language is actually "zh" (not "cn"), so I don't expect...

I think someone already made this change.

It fails for me when I have an old volume from a previous test run with an older version of postgres. Impossible to say if your problem is the same,...

Thanks for the detail. It’s not the same problem though, and Spring Boot explicitly requires the newer version of docker, so it’s kind of expected, I think (and also therefore...