spring-petclinic icon indicating copy to clipboard operation
spring-petclinic copied to clipboard

fix #1262 adding new message in Chinese

Open DaZuiZui opened this issue 2 years ago • 4 comments

adding new message in Chinese

DaZuiZui avatar Jun 12 '23 16:06 DaZuiZui

@DaZuiZui Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Jun 12 '23 16:06 pivotal-cla

@DaZuiZui Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Jun 12 '23 16:06 pivotal-cla

I can only see question marks ("????" etc.) in messages_cn.properties, in browser and also when I checkout your branch. Did it get destroyed on the way to github, or on the way to my computer?

dsyer avatar Jun 22 '23 07:06 dsyer

I see the content now, thank you. Did you test it in a browser? I think the code for Chinese language is actually "zh" (not "cn"), so I don't expect it to work yet.

dsyer avatar Jun 26 '23 16:06 dsyer

@DaZuiZui Can you link this PR to issue #1262?

To do this, you just need to add the following to the end of the PR description:

fix #1262

codespearhead avatar Jun 08 '24 20:06 codespearhead

Closing due to the lack of feedback. We can reopen if an update is provided.

snicoll avatar Jul 29 '24 12:07 snicoll