Daniel Swarbrick
Daniel Swarbrick
What advantage does running this script in Docker actually bring you? It seems like an unnecessarily complicated setup. Assuming it's a Debian or Ubuntu host, these scripts are packaged as...
I can understand the motivation to support a non-standard apt cache location, and would accept that being implemented via a command-line option. I still don't understand your motivation to run...
I don't think that depending on an all-zeros node_guid is a reliable method, since the VF node_guid can be set by the user, e.g. `echo 00:11:22:33:44:55:1:0 > /sys/class/infiniband/mlx5_0/device/sriov/0/node`. How about...
According to the manpage for `which`, it works "by searching the PATH for executable files matching the names of the arguments." In other words, this could be accomplished by omitting...
Please sign the DCO if you wish this to be considered for merging.
So, checking for a non-zero file size (if the file exists) would be a suitable test?
Yes, the shell script will be deprecated.
@sbates130272 You might want to hold off submitting any PR just yet, as it seems we will have to do some non-trivial refactoring of the collector. See #226.
There is discussion in #119 to replace both existing smartmon scripts with a new Python script and parse the JSON output of `smartctl`, which would likely avoid issues such as...
@stefangweichinger I am working on an interim refactor of the existing smartmon.py to use the official Prometheus client_python library for rendering the metrics. This will solve any quoting issues. However,...