Daniel Swarbrick

Proposal: collect mdraid metrics from sysfs instead of parsing /proc/mdstat

15

## Proposal I just discovered the that `node_md_blocks_synced` metric, which is currently parsed from `/proc/mdstat` is not very useful in trying to determine resync / check progress percentage of an...

Bogus probe_http_duration_seconds{phase="tls"} values if more than one redirect

2

### Host operating system: output of `uname -a` ``` Linux ber-prom1 4.19.0-5-amd64 #1 SMP Debian 4.19.37-3 (2019-05-15) x86_64 GNU/Linux ``` ### blackbox_exporter version: output of `blackbox_exporter -version` ``` blackbox_exporter, version...

Decode resp.Body directly, without ioutil.ReadAll

2

Since resp.Body implements the io.Reader interface, it can be decoded directly by an xml.Decoder, without the intermediate ioutil.ReadAll byte slice.

TestGRPCConnection unit test fails

12

Running `go test ./...` on a checkout of v0.22.0, the TestGRPCConnection test consistently fails as follows: ``` --- FAIL: TestGRPCConnection (0.00s) grpc_test.go:73: GRPC probe failed panic: Fail in goroutine after...

Test data in api/prometheus/v1/api_test.go overflows on 32-bit archs

2

The millisecond-resolution Unix timestamps (i.e., JavaScript-style) in the new TSDBHeadStats struct introduced by #925 will overflow on 32-bit archs ```go // TSDBHeadStats contains TSDB stats type TSDBHeadStats struct { NumSeries...

TestGoCollectorAllowList tests fail in v1.13.0 with Go 1.19

3

The following tests fail in v1.13.0 and main branch (as of writing). ``` === RUN TestGoCollectorAllowList === RUN TestGoCollectorAllowList/Without_any_rules === RUN TestGoCollectorAllowList/allow_all go_collector_latest_test.go:193: got [go_cgo_go_to_c_calls_calls_total go_gc_cycles_automatic_gc_cycles_total go_gc_cycles_forced_gc_cycles_total go_gc_cycles_total_gc_cycles_total go_gc_duration_seconds go_gc_heap_allocs_by_size_bytes...

Parse traffic request / response size histograms

2

This implements parsing of the DNS request / response traffic size histograms. Refs: #64

Initial cut of CONTRIBUTING document, containing basic guidelines for textfile collector scripts in this repo. @SuperQ Can you think of anything we need to add / remove?

TestLinuxClientLinkModes fails on s390x

5

Another test that fails on Debian CI infrastructure (s390x): ``` === RUN TestLinuxClientLinkModes === RUN TestLinuxClientLinkModes/OK client_linux_test.go:292: unexpected link mode (-want +got): []*ethtool.LinkMode{ &{ Interface: {Index: 1, Name: "eth0"}, SpeedMegabits:...

Fix misaligned struct member used in atomic operation

3

This fixes a panic caused by attempting to atomically access a struct member which is not 64-bit aligned when running on 32-bit arch, due to the smaller sync.Map struct. For...