node-exporter-textfile-collector-scripts icon indicating copy to clipboard operation
node-exporter-textfile-collector-scripts copied to clipboard
verified publisher icon prometheus-community

Add Open Compute Project log page (when available) to stats gathered on NVMe devices.

Open sbates130272 opened this issue 1 year ago • 3 comments

It would be desirable to have the nvme collector(s) gather information from the OCP stats log page as well as from the smart-log page. Note this has been discussed in the nvme-cli project. I am happy to work up a PR for this.

One question I have is if this needs to be done for the python and the shell script? Is the shell script being depreciated?

sbates130272 avatar Nov 08 '24 18:11 sbates130272

Yes, the shell script will be deprecated.

dswarbrick avatar Nov 08 '24 23:11 dswarbrick

@sbates130272 You might want to hold off submitting any PR just yet, as it seems we will have to do some non-trivial refactoring of the collector. See #226.

dswarbrick avatar Nov 17 '24 07:11 dswarbrick

Thanks @dswarbrick. I will keep a track of #226 and see how things play out.

sbates130272 avatar Nov 18 '24 19:11 sbates130272