Daniel Standish
Daniel Standish
i hesitated suggesting reverting your unrelated changes cus i didn't want to be too nitpicky but after looking again, i do think it's best to revert those changes if you...
just need to resolve conflicts here
@schattian any reason you are using multiprocessing instead of a thread?
> Yep. The thread could hang indefinitely, as the kube logs api stream could do, so I need to terminate the process. > > However, i am not very knowledgeable...
also, i'd make "private" the two methods you've added
separate question for you @schattian. suppose the stream hangs, and the pod is still running. if we terminate the process and restart logs consumption, will it get logs from the...
>> one is I think you need to kill the logging process when on_kill is called. >Sorry, i dont think i understand what's the point here in operators, if we...
> yeah thats what i was thinking, added by making the functions private. What i think happens is that the methods that are looking to be mocked are inside a...
@jplauri regarding your question about merge vs insert, i think merge is the right call. That list of issues is pretty ancient now. Merge was implemented in 2008 and by...
> I mean, GenericTransfer is meant to be used for small datasets anyway as it works in-mem Yeah I wasn't aware of that, this is my first look at generic...