Daniel Standish
Daniel Standish
Turns out we already have it set false in the main flask app config BUT.... now that we do db init from orm, and we create a distinct flask app...
> Overall looks okay. I do wonder if instead we should pass down the event itself instead. I could see custom manager classes wanting the dataset itself, so passing the...
> I wonder if the future annotations changes are going to cause heartache for #26290? Might be worth removing those here? Oh yeah I thought everything had been merged.... I...
> My personal preference would be to pass around the DatasetModel and DatasetEvent objects directly ultimately, they are still private, so, if someone wants to change it back, well, there's...
The thing is potiuk it doesn't get updated when the dag gets parsed again. Let's say your task had a bad exec config. Then it fails. You update the code...
i think it's created on dag run simply because there's no task instance record until the dag run is created. and the TI is where it's stored. i think "serializing"...
So as of recently, I made the change to run k8s pod objects through airflow's serialization process (this give us better stability when kubernetes library changed and unpickling an object...
you are suggesting that if executor config is json-serializable, then store it in serialized dag, and if not, fallback to pickling it in TI.executor_config? one thing about "json serializable" is...
Took a _quick_ look at it
It seems to me very, very odd that kubernetes client library does not support conversion to and from json and yaml, given that yaml is like... THE way to define...