Daniel Plaisted

Results 190 comments of Daniel Plaisted

We think that we can do this for projects that target .NET 8 or higher, by setting the `PublishRelease` property to true (if not already set) in the .NET SDK...

It looks like this file is generated in the intermediate output directory. I wouldn't suggest having a build pipeline which fails based on what is written to the intermediate output...

Here's the logic (or most of it at least): https://github.com/dotnet/sdk/blob/d33ef78b1e7710ce9dc461f73ff617958a6273e9/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets#L177-L241

Great suggestion. IMO, `props` and `targets` are perhaps too generic names for these templates. On the other hand, `directorybuildtargets` is sort of long. Maybe `directorytargets` and `directoryprops` would work. Or...

> What do you think of buildprops and buildtargets? In contrast to something like slnprops/slntargets (for Directory.Solution.props/targets files). That also works for me.

@jtattermusch I think you can avoid breaking existing projects in the common case by detecting and ignoring duplicate ProtoBuf items (ie my suggestion from [here](https://github.com/grpc/grpc-dotnet/issues/5#issuecomment-446413033)

@dsplaisted here, reporting for duty :) Can you explain the context here? I kind of know in general what Shimmer does, but when do you need to know what an...

The possible solution of starting with the top-level profile and using NuGet's algorithms to determine what DLLs are actually referenced sounds like the right solution. You should probably be able...

The reason for the change is that the more parsable version of the target framework (.NETCoreApp, Version=v4.5) didn't have a way to represent the platform name / version which can...

As I understand it, the NuGet API where this value was coming from (I think it was `NuGetFramework.DotNetFrameworkName`) was reverted to only return the TargetFramework. If you want to know...