Daniel Plaisted

Results 190 comments of Daniel Plaisted

Due to the order things are imported in, I'm not sure we can make this work without requiring the Directory.Build.props to set `UseArtifactsOutput` to false (or some other change to...

@tmat Looks like some of the new EnvironmentVariableNamesTests are failing.

This should be fixed in 7.0.200 via #28405. Thanks a bunch @marcin-krystianc for the detailed information which enabled us to investigate and address this!

It looks like the `ext.www.nuget.org_nuget_public-remote-cache` package source doesn't (or didn't at the time) include the 6.0.13 version of the `Microsoft.NETCore.App.Runtime.linux-x64` package.

Looks like similar failures as in #39084 and #39088.

I'm investigating this, and am experimenting in this PR: #39144

Looks like I'm going to disable these tests for now: https://github.com/dotnet/sdk/issues/39172

@dotnet/illink-contrib Could someone take a look at these test failures? ``` System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than the size of the collection. (Parameter...

Are `$(MSBuildProjectExtensionsPath)$(MSBuildProjectFile).*.props` and `$(MSBuildProjectExtensionsPath)$(MSBuildProjectFile).*.targets` not considered public extensibility points? I would expect them to be active during evaluation for restore as well as during a normal eval. This seems like...

> Yes its considered a breaking change if: > > 1. You are generating files to $(MSBuildProjectExtensionsPath) > 2. You need them imported for restore and build > The idea...