Daniel Plaisted

Avoid downloading MSBuild SDKs from NuGet on the VS UI thread

16

The MSBuild NuGetSdkResolver may download NuGet packages during MSBuild evaluation, which can happen on the UI thread in VS. Some discussion of this: https://github.com/microsoft/msbuild/issues/4025 We are [adding some features to...

Add code formatting rule to add newlines at the end of code files

5

@stephentoub has [pointed out](https://github.com/dotnet/corefx/pull/1851#discussion_r31315254) that text files should end with a newline. This PR adds a code formatting rule to do this for C# source code files.

Update handling of SelfContained and RuntimeIdentifier properties when specified on the command line

1

Fixes #21677 Also changes how the SelfContained and RuntimeIdentifier properties flow between projects when they are specified on the command line. More details are in the comments and the breaking...

Workload update reports failure when manifest packages aren't found on feed

3

### Repro Run the following: `dotnet workload update --source ` ### Expected Messages saying "Advertising manifest not updated. Manifest package for doesn't exist.", as added in #24678 ### Actual >...

AppHost selection doesn't work well with DisableImplicitFrameworkReferences or RuntimeFrameworkVersion

1

There are a couple of issues with app host selection: - Some projects use `DisableImplicitFrameworkReferences` to disable any package references, downloads, etc. that aren't explicitly specified. In some cases this...

Add MSI Installation Tests

5

This PR has a messy commit history which will probably be rebased before merging. But it is ready to start looking at. On Windows, when the .NET SDK is installed...

Package reference alias tests are disabled

4

The tests in `GivenThatWeHaveAPackageReferenceWithAliases` have started failing somewhat consistently in CI. I haven't been able to reproduce the issue locally. The failures look something like this: ``` /private/tmp/helix/working/B27409DB/w/A434093A/e/testExecutionDirectory/CanBuildProje---B79B2BCA/Project/Project.cs(9,13): error CS0118:...

Update NuGet package

1

The [NuGet package](http://www.nuget.org/packages/Krs.Ats.IBNet/) was last updated in 2012, but there are commits to the repository from 2013. Can the NuGet package be updated?

Add design for simplifying workload versioning

3

This proposal simplifies how workload versions are expressed and understood. Currently, the design mainly covers the proposed changes to the user experience for workloads. That is the primary thing we...