Irwin D'Souza

Results 88 comments of Irwin D'Souza
trafficstars

I'm ok with using a new name as I've already set up some infra to get the post-restore options, i.e.: https://github.com/eclipse-openj9/openj9/blob/58fb3c25e7c02616411b2bb6e9d18be2af3b519a/runtime/compiler/control/OptionsPostRestore.cpp#L43-L44 That said, in normal startup we don't check the...

> The VM will parse the new option. We can expose a flag/API about whether the new option is found or not to JIT, if JIT does not parse the...

@hangshao0 To check if the SCC is disabled post-restore, do I just check if `J9SHR_RUNTIMEFLAG_CACHE_INITIALIZATION_COMPLETE` is not set in `vm->sharedClassConfig->runtimeFlags`? Or do you recommend I just search for the `-Xshareclasses:disableOnRestore`...

Hm, well because we need to get the code in by Friday and the JIT changes will have to wait until the SCC changes get merged in, I'll just explicitly...

Looks reasonable to me.

I ran into this while working on AOT MH support; you need this patch: ``` diff --git a/runtime/compiler/env/VMJ9.cpp b/runtime/compiler/env/VMJ9.cpp index b6c049e79c..733b502e99 100644 --- a/runtime/compiler/env/VMJ9.cpp +++ b/runtime/compiler/env/VMJ9.cpp @@ -8887,7 +8887,7 @@...

> Somewhat hilariously, I tried running `!whatis 0xc2e58` in `jdmpview` just to see what it would say, and it appears that `jdmpview` also crashed with exactly the assert `aMethod 0xc2e58...

We don't provide access to any machines that are attached to the build farm both to prevent resource constraints and for security reasons; you'll need to find an alternative way...