Allow SVM assertions to be ignored

[cjjdespres]

trafficstars

If the option TR_IgnoreAssert is enabled for a particular compilation and the environment variable TR_svmAssertionsAreFatal is not set, SVM assertions will now be non-fatal even in DEBUG or PROD_WITH_ASSUMES builds. This matches the behaviour of normal TR_ASSERT assertions, aside from the possibility of overriding TR_IgnoreAssert with that environment variable.

[cjjdespres]

Attn @mpirvu. Since SVM assertions are non-fatal by default, I think it makes sense to allow them to be ignored with TR_IgnoreAssert like other non-fatal assertions - the definition of TR::assertion is here. Maybe @dsouzai could also comment.

[dsouzai]

Looks reasonable to me.

[mpirvu]

jenkins test sanity zlinux jdk17

[mpirvu]

jenkins test sanity zlinux jdk17

[mpirvu]

I don't understand why the zlinux build failed.

[mpirvu]

jenkins test sanity zlinux jdk17

[pshipton]

12:12:18  /home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/openj9/runtime/compiler/runtime/SymbolValidationManager.cpp: In static member function 'static bool TR::SymbolValidationManager::assertionsAreFatal()':
12:12:18  /home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/openj9/runtime/compiler/runtime/SymbolValidationManager.cpp:1607:4: error: control reaches end of non-void function [-Werror=return-type]

[cjjdespres]

The build failed because in a non-debug configuration there would be no return at the end of the function if fatal were false. I've force-pushed to supply the missing return. (I tested this with a debug build, so didn't catch that).

[mpirvu]

jenkins test sanity zlinux jdk17