openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Refactor TR::CompilationInfoPerThreadBase::wrappedCompile

Open dsouzai opened this issue 4 years ago • 6 comments
trafficstars

TR::CompilationInfoPerThreadBase::wrappedCompile is a ridiculously big method. A lot of the code within should be moved into smaller functions.

dsouzai avatar Apr 20 '21 17:04 dsouzai

@dsouzai could you please assign this task to me?

singh264 avatar Jul 15 '21 16:07 singh264

Me and @ymanton (who is a reviewer for my work associated with this issue) will make progress after I have a machine that is setup to build and test OpenJ9, and @ymanton I would like to inquire about obtaining a community machine that is already setup in order bypass my local Mac machine setup, which is currently blocked because of my Apple account, and build and test the code changes for this issue.

singh264 avatar Jun 03 '25 22:06 singh264

We don't provide access to any machines that are attached to the build farm both to prevent resource constraints and for security reasons; you'll need to find an alternative way to build and test locally.

dsouzai avatar Jun 04 '25 16:06 dsouzai

You can try using GitHub's Codespaces feature; every user gets some free time per month. Hopefully building OpenJ9 doesn't exhaust it too quickly.

Aside from that contributors should feel free to ask a maintainer to launch tests against their PRs, especially to cover testing on platforms that aren't easily accessible to the average person.

ymanton avatar Jun 04 '25 16:06 ymanton

Person like me and other volunteer engineers who contribute to the OpenJ9 project can try the GitHub Codespaces feature, which is an action I will do, in order to build and test OpenJ9, and the opportunity to request reviewers to test the code changes in a PR is good because it gets the work done in a fast and transparent way.

singh264 avatar Jun 05 '25 22:06 singh264

Way to move forward will be to build OpenJ9 with docker on my local Mac machine because the default GitHub Codespaces Linux machine built OpenJ9 is 90 minutes and this seems to be slow for making good progress on this issue.

singh264 avatar Jun 09 '25 21:06 singh264