Dan Nizri

Results 39 comments of Dan Nizri

Hi @pubiqq, I think the Force RTL layout direction developer option should only be used to test out the alignment of Views within their parent ViewGroups, as opposed to content...

That's still not a valid setup because the [strings in the catalog](https://github.com/material-components/material-components-android/blob/83edbc4c496137090017d2849bd1748254feb433/catalog/java/io/material/catalog/topappbar/res/values/strings.xml#L73-L75) are not translated.

Gotcha, so you found a way to do that without breaking the overall alignment?

It's basically the following, for short LTR text with an RTL device config, we want the alignment to be on the right: **Before https://github.com/material-components/material-components-android/commit/841f2295921b4eed8bd16bb72b28d4ef7ca7cfa5** | **After https://github.com/material-components/material-components-android/commit/841f2295921b4eed8bd16bb72b28d4ef7ca7cfa5** :-------------------------:|:-------------------------: ![image](https://user-images.githubusercontent.com/1420597/181276573-a753b96f-e0a9-462a-a2f0-be259710f419.png) |...

Sorry can you also post an After video with the device language set to an RTL language? (not just Force RTL)

Hey @OxygenCobalt, I spent some time looking into this and we can match the new spec by making the following style updates: ``` 48dp 4dp 4dp 4dp 4dp ``` ```...

@OxygenCobalt thanks for testing. > You never fixed the padding that the overflow icon applied to compensate for it's smaller width. Hmm gotcha. That doesn't seem to matter though, right?...

🤦‍♂️ ughhh you are totally right. Now I shall restart the process of landing this change... Thanks for finding this!

See explanation on https://github.com/material-components/material-components-android/issues/2830. Additionally, we intentionally disabled the `RtlTextDirectionHeuristics` for `CollapsingToolbarLayout` in https://github.com/material-components/material-components-android/commit/841f2295921b4eed8bd16bb72b28d4ef7ca7cfa5 to fix several bugs related to non-RTL text being misaligned within an RTL device language.