material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

Published 20 hours ago • verified publisher icon material-components

[CollapsingToolbarLayout] Use more accurate way to determine text direction

Open pubiqq opened this issue 2 years ago • 5 comments

Fixes https://github.com/material-components/material-components-android/issues/2830

Before After

Also see https://github.com/material-components/material-components-android/issues/2830#issuecomment-1197042582 and https://github.com/material-components/material-components-android/issues/2830#issuecomment-1197075367.

pubiqq avatar Jul 18 '22 00:07 pubiqq

See explanation on https://github.com/material-components/material-components-android/issues/2830.

Additionally, we intentionally disabled the RtlTextDirectionHeuristics for CollapsingToolbarLayout in https://github.com/material-components/material-components-android/commit/841f2295921b4eed8bd16bb72b28d4ef7ca7cfa5 to fix several bugs related to non-RTL text being misaligned within an RTL device language.

dsn5ft avatar Jul 26 '22 23:07 dsn5ft

OK, I've made some changes that are supposed to resolve the text alignment issues. Could you reopen the PR so I don't have to create a duplicate?

pubiqq avatar Jul 27 '22 13:07 pubiqq

I actually can't reopen it either: image

dsn5ft avatar Jul 27 '22 13:07 dsn5ft

Could you please try again?

pubiqq avatar Jul 27 '22 14:07 pubiqq

Done.

pubiqq avatar Jul 27 '22 16:07 pubiqq

btw, blocked by https://github.com/material-components/material-components-android/pull/2906

pubiqq avatar Jan 31 '23 11:01 pubiqq