David Smiley

Planned commit message after the first line: ``` • CloudSolrClient builders use reflection to instantiate ZkClientClusterStateProvider when needed • CollectionAdminParams constants • CollectionStateProps constants • SliceStateProps constants • ReplicaStateProps constants...

I think it's done and I've addressed comments. I would love to see this merged soon so as to unblock other efforts that touch lots of files. If nobody has...

I ran into this problem today -- I'm glad others are working on it. Unless I've misattributed this issue, I think this problem is not related to a "custom sort"...

Unless I'm missing something (maybe I looked too quickly at this PR), the change seems invalid to me. If someone registers highlighters, they can be chosen at runtime via `hl.method`....

> maybe I should update ZkConfigSetService#checkConfigExists in this PR to check if the config dir is not empty and contains solrconfig.xml file ? No; it is unrelated to this PR.

SOLR-15258 is a refactoring that we might say can include this or maybe not; it doesn't matter I suppose. It's 9.0 only so there is more fluidity. I suppose a...

I like it -- especially treating offset+limit the same as limit, and for monotonically increasing the over request to a point. but I'm not the ideal reviewer. @yonik , @joel-bernstein...

Feel free to add another line of test code to test that one.

> use `!` rather than `== false`, no? Using `== false` is especially prevalent in Lucene and it's a deliberate choice; I prefer it as well. It reads in a...

BTW, not saying there's a bug here, but take care to ensure that metrics are unregistered properly as it could be a nasty memory leak if not -- https://issues.apache.org/jira/browse/SOLR-13677