David Smiley

AbstractDistanceCalculator indeed isn't doing much so I support removing it. Despite shapes being re-usable, it doesn't mean that all API call sites are in a position to possess a re-usable...

To put tests in a different package from the code they are testing? That sounds unusual but yeah, possible. It's useful to use "package" visibility to expose methods to a...

I don't love underscores in methods but this method is tightly related to calcBoxByDistFromPt, hence why I named it this way. Perhaps instead: calcBoxFromCircleGetYHorizAxisDEG ('Get" substituted for underscore) Yes its...

You are right of course. Thanks for reminding us of this omission.

Z dimension is kind of a gray area; not particularly well supported. Feel free to file a PR to rectify the situation. I plan to do a release next week...

FYI `Geo3dShape` in Lucene's spatial module should be copied into Spatial4j as part of this issue. Also note that the maven dependency / coordinates may wind up changing dependent on...

No change (lack of time/project).

After #138 then I think I'll take a stab at this.

Ehh; I think I'll let it be after all since Solr will now be able to include JTS and as-such the pain point I felt here should vanish. That said...

This choice is made here: https://github.com/locationtech/spatial4j/blob/master/src/main/java/org/locationtech/spatial4j/io/WKTReader.java#L319 It seems this ought to be a configuration option of the parser, wether to call ShapeFactory.build() or ShapeFactory.buildOrRect()