David Smiley
David Smiley
I definitely don't believe in mutable static variables, sorry. The right place for the setting is on SpatialContextFactory, which the ShapeWriter's have access to in their constructors. The static `makeNumberFormat()`...
> Would not it make sense to use the same precision as defined through the precision model for JSON/WKT exports? +1 > While the precision seems to be set/used by...
Spatial4j would probably have not existed as-such (as its own lib) were it not for JTS's former license. It was imperative that Spatial4j have useful functionality without depending on JTS....
Garbage in, Garbage out -- no? Maybe I'm probably missing your point. What do you propose that Spatial4j should do/not-do?
If you are proposing that the shape be eagerly validated (on construction) then that would definitely be a configurable option. I want to avoid re-validation of already validated data. Consider...
Hi; looks interesting. I hope to give it a finer look this weekend. Have you seen SpatialPrefixTree in Lucene spatial? It already deduces the proper geohash length for the desired...
The grid cells do get smaller towards the poles but only longitudinally. In other words, they get skinnier, but they have the same height relative to anywhere else. So for...
It would be nice to empirically test/evaluate what the precision is by developing a simple program or test, that way it can be better understood. At least your patch makes...
Please take a look at the feature-branch I added for your commit. I made some modifications. I'm have pretty basic GitHub skills but I believe you can comment at the...