David Sanders

Results 117 comments of David Sanders

@jdalton, here you go: https://github.com/dsanders11/electron-quick-start/tree/dynamic-import-native-module-crash You can run `npm run rebuild` to see the go-right case when the native module is built for Electron.

Since `electron/patch-conflict-fixer` looks to be creating a temp branch and then deleting it, probably not much hope that approach would work with forks. Will close this, but hopefully something changes...

> Confusing but they're two different things @MarshallOfSound oh, that did indeed confuse me. Does `PatchUp` have a repo somewhere?

@codebytere, doing a basic repro test ("Save As", close window, "Open") doesn't repro for me - can you check if this is still a valid issue for you?

Gonna chime in with my perspective here as an individual contributor to a handful of Electron repositories. CLA does have the advantage of being less annoying for contributors since it's...

> Potentially related: on Windows, when switching versions fairly quickly, i keep seeing: Hm, that's probably tripping over Windows quirks, unfortunately. With the change to using `@electron/fiddle-core` there's a bottleneck...

I think it's fine to let it throw an error in that case, since it would mean there's a bug and it'll be easier to debug if we let it...

@jmercouris, this is expected behavior. You're registering the scheme as `standard` and then trying to load a URI which does not conform to the expected syntax. From the docs: >...

Are we purposely not giving this a full deprecation cycle and going straight to yanking it?