electron icon indicating copy to clipboard operation
electron copied to clipboard

feat: remove File.path

Open nornagon opened this issue 1 year ago • 4 comments

Description of Change

It's time.

Checklist

Release Notes

Notes: Removed nonstandard File.path extension from the Web File API.

nornagon avatar May 06 '24 21:05 nornagon

Are we purposely not giving this a full deprecation cycle and going straight to yanking it?

dsanders11 avatar May 06 '24 22:05 dsanders11

Are we purposely not giving this a full deprecation cycle and going straight to yanking it?

It was quasi-deprecated in https://github.com/electron/electron/pull/38776, though it didn't get a breaking-changes.md callout.

nornagon avatar May 06 '24 22:05 nornagon

Moved the deletion to 32.x

nornagon avatar May 06 '24 22:05 nornagon

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • [x] 🏷️ Pull request is labeled as https://github.com/electron/electron/labels/semver%2Fmajor
  • [x] 📢 Are called out as removed in docs/breaking-changes.md
  • [x] 📝 Are fully removed from the docs
  • [x] ⌨️ All relevant code is removed

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

electron-cation[bot] avatar May 06 '24 22:05 electron-cation[bot]

Release Notes Persisted

Removed nonstandard File.path extension from the Web File API.

release-clerk[bot] avatar May 15 '24 18:05 release-clerk[bot]

Whats replacing : File.path ? Concrate case : user drag a file and the electron app want to save the new version in the same folder, how to know what's the original folder ?

Makio64 avatar Aug 13 '24 19:08 Makio64

@Makio64 Check the breaking changes doc: https://github.com/electron/electron/blob/main/docs/breaking-changes.md#removed-filepath

MarshallOfSound avatar Aug 13 '24 19:08 MarshallOfSound