fiddle icon indicating copy to clipboard operation
fiddle copied to clipboard

Error During Version Download Leaves UI in Bad State

Open dsanders11 opened this issue 2 years ago • 2 comments

A failed download will leave the action button in a bad state where you'll have to switch versions to recover. Also looks like it could happen in situations where you are offline, change versions, then come back online.

dsanders11 avatar Jun 06 '23 22:06 dsanders11

Potentially related: on Windows, when switching versions fairly quickly, i keep seeing:

Failed to spawn Fiddle: EPERM: operation not permitted, unlink 'C:\Users\codebytere\AppData\Roaming\Electron Fiddle\electron-bin\current\electron.exe'

and then have to change versions again to get it to run

codebytere avatar Jun 12 '23 10:06 codebytere

Potentially related: on Windows, when switching versions fairly quickly, i keep seeing:

Hm, that's probably tripping over Windows quirks, unfortunately. With the change to using @electron/fiddle-core there's a bottleneck on electron-bin\current since versions are unzipped on-demand to save disk space, and Windows can get finicky when you are touching files a bunch. We may be able to mitigate it by using graceful-fs in the right spots in @electron/fiddle-core (see graceful-fs code comment which explains some of the Windows quirks).

@codebytere, just to confirm, you're seeing that behavior on 0.32.9? I would have thought #1367 would help mitigate that by not doing the unzip until a run happens, making switching between versions not touch electron-bin\current, but maybe there's some edge case there still.

dsanders11 avatar Jun 12 '23 17:06 dsanders11