Drew Powers

icon indicating a website link https://pow.rs

icon company @figma icon location Denver, CO icon location Co-creator @withastro, creator @terrazzoapp, @openapi-ts. Mucking up other peoples’ code since 2005

Results 459 comments of Drew Powers

Generates invalid types when API paths are nested

Yeah this is a tricky one! I will admit this flag has always had some rough edges for reasons like this. Loose pattern-matching in TS isn’t as robust as runtime...

[openapi-typescript] Incorrect type generated for nullable objects

You’re right I don’t think we’re testing for this. This should be an easy fix and we’d welcome a PR on it from anyone 🙂 > As a side note,...

onRequest: must return new Request() when modifying the request

Yeah this is tricky. The “returning a new Request” restriction doesn’t come from this library, but the fetch API itself in all browsers. We just throw an error that makes...

Fix invalid $ref index into path

I’ll merge and add a manual changeset (for this and a few other PRs)

fix(enum-values): access optional prop child props

Sorry for the delay in reviewing. We’d be happy to accept this PR! Please just add a `patch` changeset (see comment) and we can merge & release 🙂

Throw error on error and data property be defined

It’s intentionally the design that this library doesn’t throw an error to match the fetch spec. This is intended to be lower-level and flexible. [The docs have a simple example...

Required in path converts to required in query too

Just so I understand, is `site_id` declared only once as a `path` param? Or is it also a `query` param as well?

Required in path converts to required in query too

Also even if you’re not allowed to share the entire schema, it’d be immensely helpful if you were able to just create a stub test for [path-item-object.test.ts](https://github.com/openapi-ts/openapi-typescript/blob/main/packages/openapi-typescript/test/transform/path-item-object.test.ts) that fails. You...

Don't remove `null` type if a default is present.

Released in 7.7.2!

`SuccessResponseJSON` and `ErrorResponseJSON` always return `never`

That’s a good suggestion, and we’d welcome a PR for those. Those are just helper utils that people can use or not use, and we make no guarantees about breaking...