Drew Powers

Results 459 comments of Drew Powers

Let me know if you’d rather publish as a patch or minor; either is fine.

Thanks for suggesting. I’m not opposed to adding an additional check here, if that would satisfy this. Just to clarify, are you proposing something like the following? ```diff export function...

Ah that’s doable. Wasn’t sure if it was a header param or something passed in the request body. Would accept a PR for this with tests! If additional work is...

> But I don't think the fetch function has access to the OpenAPI schemas for the specific paths, does it? It doesn’t; that’s the tradeoff with openapi-fetch. In order to...

Just to add a little more context: [this was a feature we talked about and delayed](https://github.com/openapi-ts/openapi-typescript/issues/1126) because we were determining how people used this library. When paired with TanStack Query,...

Oh and yes @gzm0 to your comment, I was interpreting this the need to silently fail without throwing an error. Expired tokens are a great case where it’s helpful to...

@romainmenke Those are all great points, thanks for raising. I was originally trying to solve for multiple things here, but agree that may be too big a change here: -...

But all that said, I’ll make this PR easier to review by **NOT** adding vendor here, and we [could review that in a followup](https://github.com/design-tokens/community-group/issues/245). I’ll restore the current behavior of...

> Making parsing easier is nice, but I'm not convinced the current string values are a significant blocker or source of bugs for implementors. I was of this opinion until...

DTCG meeting just met and this proposal has been approved! 🎉. Will update this PR with all the suggested changes