Drew Powers comments

Results 459 comments of


                                            Drew Powers

chore(deps): update pnpm to v9.15.9

note: pnpm can be bumped to latest; just takes updating `packageManager` with it

ResolveError: Failed to load https://**.*.com//**: 404 Not Found

So the fetch mechanism _technically_ changed from 6.x to 7.x, but only in that it moved from undici to [node-fetch via Redocly](https://github.com/Redocly/redocly-cli/blob/main/packages/core/src/utils.ts#L62). Redocly is a very widely-used tool though, and...

feat: allow form data through default body serializer

Thank you for this fix! I’d accept this change if you also **added a test** that was failing before your fix, and passes with. Also be sure to add a...

feat: allow form data through default body serializer

Looks good! But I see we have a type error in the tests we should probably fix in `openapi-fetch/index.d.ts`.

Improve querySerializer

Closing just to clean up open PRs, but we’ll accept this exactly as-written if tests are added. Feel free to reopen with tests (or for anyone else following, feel free...

Replace `Array<T>` with `Iterable<T>` in request parameters

This seems reasonable! I’d welcome a PR for this

Encode the request body if `Content-Type` header is `x-www-form-urlencoded`

This approach looks good to me, and good test! But before we merge, we’ll want to: 1. Use the merged/normalized headers like the comment mentioned 2. Add a `patch` **changeset**...

Encode the request body if `Content-Type` header is `x-www-form-urlencoded`

@obulat Still willing to accept this PR with the changes mentioned!

Encode the request body if `Content-Type` header is `x-www-form-urlencoded`

Oh no worries at all; the maintainers and I all had individual things come up that made reviews earlier in the year slower than we’d like too. Thanks again for...

Requests made by client can't be intercepted by msw in testing environment if client is created before msw server starts listening

I haven’t gotten to the root of “why” this is happening in msw (I’m not familiar with its internals). But `createClient()` is basically instant. It does no “work” other than...