D R Siddhartha

Results 11 comments of D R Siddhartha

> I suspect the changes will look very differently once you start supporting those limits as well Yeah I think it's better I complete with other constraints as well, this...

For hard limit on file size, I was thinking maybe having a safety margin on currently stored file size will be better than having to get the data size of...

Will add custom batch handler tests soon.

> We need tests that check how different combinations of options being defined affects whether or not the batch handler is enabled. This is remaining, I will put them up...

Hmm `:noindex:` doesn't seem to fix the `sphinx-build` error. Any clues how to fix it? The error is being reported because of two `__init__` methods in the documentation.

But shouldn't the problem arise when the file is being replaced instead of being overridden? In the example you gave, the data is being stored to the target file after...

I guess then we should proceed with a warning log to the user, as you suggested. We can compare the file objects of the exporter instance and the one of...

A simple solution of detecting an overridden file that I thought of was checking if the exporter's file attribute points to the same file as the one opened in `_start_new_batch`...

The file attribute could be moved to `BaseItemExporter` as we want it in every exporter. Though I should ask you first, @Gallaecio, does this fix seem feasible enough to move...

Hey I'll look into this!