cve-bin-tool icon indicating copy to clipboard operation
cve-bin-tool copied to clipboard

Add package test data for kerberos

Open Niraj-Kamdar opened this issue 4 years ago • 3 comments

Niraj-Kamdar avatar Jun 04 '20 17:06 Niraj-Kamdar

Adding the "good first issue" flag on this one, so for anyone who is doing this as a first issue...

Instructions on how to add this type of test: https://github.com/inAdding the "good first issue" flag on this one, so for anyone who is doing this as a first issue...

Instructions on how to add this type of test: https://github.com/intel/cve-bin-tool/blob/master/test/README.md#adding-new-tests-signature-tests-against-real-files

You probably also want to read the rest of that readme file, particularly the bit on how to run only the new tests you added and how to run long tests (this will be a long test), which is near the top of the checker readme file: https://github.com/intel/cve-bin-tool/blob/master/test/README.md

The kerberos checker is here: https://github.com/intel/cve-bin-tool/blob/master/cve_bin_tool/checkers/kerberos.py

tel/cve-bin-tool/blob/master/test/README.md#adding-new-tests-signature-tests-against-real-files

You probably also want to read the rest of that readme file, particularly the bit on how to run only the new tests you added, which is near the top! Note that package tests are "long tests" so you'll need to enable those with the LONG_TESTS flag (again, described at the top of the file:

The kerberos checker is here: https://github.com/intel/cve-bin-tool/blob/master/cve_bin_tool/checkers/kerberos.py

terriko avatar Sep 08 '20 23:09 terriko

Hey I'll look into this!

drs-11 avatar Oct 06 '20 19:10 drs-11

@Niraj-Kamdar I'm not sure why there are two kerberos test_data files. Is kerberos.py for the user client of kerberos and kerberos_5.py for the main libraries?

drs-11 avatar Oct 06 '20 20:10 drs-11

This should be fixed by #2509.

inosmeet avatar Feb 03 '24 10:02 inosmeet

Yeah, I think we can close this one.

terriko avatar Feb 05 '24 22:02 terriko