Dave MacFarlane

[cleanup] PaginationLinks as functional tsx component

1

The PaginationLinks was the first React component ever written in LORIS. As such, it is currently a class based component written in Javascript. It also dated from a time where...

The dates on the menu filter in the publication module are not formated according to the user's locale as other places. They should be formatted using an Intl.DateTimeFormat formatter.

[dqt] Remove old dqt module

1

Remove the old CouchDB based "dqt" module which has been replaced by the "dataquery" module. All projects that I've asked who still use the "dqt" have overrides, so there is...

The "Terms of Use" are not visible on the login page in the mobile view. When requesting an account, it provides an error saying the terms of use were not...

There are a number of functions in Utility.class.inc that have been there for years. get??Instruments have printed a deprecation warning for 4 years. Other methods have been throwing exceptions. It's...

[SQL] Faster loading of raisinbread test data

1

This speeds up `make testdata` (and the GitHub Actions tests in general) faster by converting the format of loading from one `INSERT` statement per row to a bulk `LOAD DATA...

[Forms] Redirect on successful save

2

This updates the NDB_Form class to respond with a `303 See Other` after a successful page and redirect to the same page. This (in addition to being a better practice)...

The parameter_type_override from the dictionary and datadict module allows a field description to be overridden. However, there is one override per language. This does not make sense in a multi-lingual...

All logged in user session data is private. There is no reason to restrict the session_cache_limiter to the API. (In fact, it is a bad idea.)

The showPasswordExpiryScreen method in SinglePointLogin redirects to a page that does not exist, and does it in a very hacky way. This removes it to avoid confusion with the login...