Dridi Boukelmoune

Results 155 comments of Dridi Boukelmoune

While I agree that `env` should not be shadowed, you probably don't need it. Your example works fine without env: ``` bash A=aaa B=bbb mv ... ``` The `env` command...

@bric3 As I said, I agree with you. I highlighted the fact that you don't need `env` in the example you give, hoping that would help you until it's fixed...

Any reason why `string.replace('\\', '/')` wouldn't do the trick? Naive question, not a windows user myself.

I don't know about advantages of having a js format, but I was hoping to manipulate the json (with `jq` or something else) to ignore lines that should always have...

That's good news, I'm looking forward to kcov 34 then, hopefully it will also work with binutils 2.29 (#215). This is off-topic here though, sorry for the noise.

Do you have some `User-Agent` headers to share to add some test coverage?

Rebased against current master to solve the trivial merge conflict. I switched to more explicit `tansport::top_*()` methods as suggested. Not addressing other review items, yet.

Can't you grab it at init time? https://github.com/varnishcache/varnish-cache/pull/3772

In the VMOD function where you set up your filter, grab the PRIV_VCL and put it in a dynamic PRIV_TASK that can be queried from a VRT_CTX from the init...

I know: 6c7cf83a79ab3570b522c650af9dfb725156482b. I built varnish on alpine thanks to distrobox (bob on steroids) and the failure was not obvious. Unlike the failure I had on FreeBSD and SunOS where...