andrew morton

Results 88 comments of andrew morton

This seems like it's still an open issue right?

We've been getting this for a long time on ruby 2.3.1 in sidekiq jobs. I'd never bothered trying to track down the cause so I'm excited to see this thread!

@ruckus in the OAuth2 branch you're moving to Faraday. Would you consider pulling some of that work forward into a separate PR to help address these threading issues?

Do we have to worry about setting the global version introducing breaking changes? Like if I'm upgrading do I want to lock this at a lower version?

That makes sense. It kind of an interesting versioning strategy if only adds additions. Typically versions are used to introduce breaking changes... so glad they haven't had to do that...

The fact that Rails 3.2 got support for Ruby 2.2 definitely lessens the need to support older versions of Ruby. Is there something to encourage you to drop the old...

A year later, now that [Ruby 2.2 is unsupported and 2.3 will become unsupported in March](https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/) it seems like a reasonable time to start looking at versions to deprecate. Maybe...

Yeah might be worth moving the minor version code out of the Item service and into ServiceCrud where other classes could use it.

Give https://github.com/ruckus/quickbooks-ruby/issues/362 a look. It's got quotes from my support request to Intuit. They seem to say they don't support those queries which I found very disappointing. You might want...