quickbooks-ruby
quickbooks-ruby copied to clipboard
Bump CompanyInfo's minorversion to 3
I spent a while wondering why the SubscriptionStatus didn't match what QBO showed on: https://developer.intuit.com/docs/0100_quickbooks_online/0100_essentials/000800_manage_your_apps/quickbooks_online_subscription_states
Then I found this in https://developer.intuit.com/docs/api/accounting/companyinfo
And at that point, little hint "returned in the SubscriptionStatus attribute of the CompanyInfo resource (with query parameter minorversion=3)" made a lot more sense ;)
Nice find. It is probably worth considering running with the latest minorversion globally by default. These minorversions usually just add new features so the chance of breakage is limited. There are fixes like with the Reports API in mv=3 (and other fixes) so users doing workarounds there might have breakage. Then again maybe there is not enough features in these minorversions to bother making the default.
Yeah might be worth moving the minor version code out of the Item service and into ServiceCrud where other classes could use it.